[v12] feat(ui-list): List rework #2308
Conversation
|
git-nandor
force-pushed
the
INSTUI-4876_list_rework
branch
from
19734f7 to
16b5427
Compare
git-nandor
force-pushed
the
INSTUI-4876_list_rework
branch
from
16b5427 to
dc40cb4
Compare
adamlobler
left a comment
adamlobler
left a comment
There was a problem hiding this comment.
List items aren’t getting the proper tokens for some reason. The text color should be white in the dark theme, and the font family should change as well. Maybe they’re not using the inlineListItem / listItem CSS values.
| const generateStyle = ( | ||
| componentTheme: InlineListItemTheme, | ||
| componentTheme: NewComponentTypes['InlineListInlineListItem'], | ||
| props: InlineListItemProps | ||
| ): InlineListItemStyle => { |
There was a problem hiding this comment.
I see a marginBottomDefault token in InlineListInlineListItem which I don't see here.
There was a problem hiding this comment.
The marginBottomDefault token will not be used, and the designers have already removed it in the latest version.
git-nandor
force-pushed
the
INSTUI-4876_list_rework
branch
from
dc40cb4 to
d8de7ed
Compare
Solved. The tokens now receive the correct values. |
git-nandor
force-pushed
the
INSTUI-4876_list_rework
branch
from
d8de7ed to
aa4bea1
Compare
| makeStyleProps = () => { | ||
| const { size, delimiter, spacing } = this.props | ||
| return { | ||
| size, | ||
| delimiter, | ||
| spacing | ||
| } |
There was a problem hiding this comment.
Is there any particular reason why you're extracting props in the index.ts files?
There was a problem hiding this comment.
This ensures that only the necessary props are passed to the theme.ts file for style generation. Similar to ui-rating, I think this is a clean and effective approach.
There was a problem hiding this comment.
@git-nandor I checked it and I cannot see a smiliar approach in ui-rating?
git-nandor
force-pushed
the
INSTUI-4876_list_rework
branch
2 times, most recently
from
0be30e8 to
9abad94
Compare
git-nandor
force-pushed
the
INSTUI-4876_list_rework
branch
from
9abad94 to
e13556a
Compare
INSTUI-4876
INSTUI-4877
Summary
Migrated List and InlineList component from the old theming system.
Test plan
On the documentation page, verify that everything displays and works correctly.
Co-Authored-By: 🤖 Claude