feat(ui-file-drop): migrate to new theming system #2309
+18
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyenjoyer
commented
Dec 15, 2025
| fileDropLabelContent: { | ||
| label: 'fileDrop__labelContent', | ||
| display: 'block', | ||
| backgroundColor: componentTheme.backgroundColor, |
Contributor
Author
There was a problem hiding this comment.
This is a new token. View has to be migrated to the new theming system first so all of the docs examples will be working fine in dark themes (View is assigned to renderLabel that hides the original background).
|
adamlobler
reviewed
Dec 17, 2025
Collaborator
adamlobler
left a comment
adamlobler
left a comment
There was a problem hiding this comment.
Everything looks good. I just want Dorka to check it visually to confirm whether the token values are okay as they are or if we need to update them, because right now the hover states aren’t visible at all. I can see a small difference in the border color, but it’s hard to notice.
hajnaldo
approved these changes
Dec 17, 2025
git-nandor
approved these changes
Dec 19, 2025
balzss
approved these changes
Dec 23, 2025
| state: FileDropStyleProps | ||
| componentTheme: NewComponentTypes['FileDrop'], | ||
| params: StyleParams, | ||
| _sharedTokens: SharedTokens |
Contributor
There was a problem hiding this comment.
nitpick: i think this param can just be omitted if not used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INSTUI-4793
ISSUE:
FileDrop is migrated to the new theming system
TEST PLAN: