Skip to content

[v12] feat(ui-tag): rework Tag #2310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ToMESSKa wants to merge 1 commit into
base: v12
Choose a base branch
from
Open

[v12] feat(ui-tag): rework Tag #2310

ToMESSKa wants to merge 1 commit into from
+74 −115

Conversation

@ToMESSKa
Copy link
Contributor

@ToMESSKa ToMESSKa commented Dec 16, 2025 •
edited
Loading

INSTUI-4811

ISSUE:

  • Badge needs to be migarted to the new theming system

TEST PLAN:

@ToMESSKa ToMESSKa self-assigned this Dec 16, 2025
@ToMESSKa ToMESSKa changed the base branch from master to v12 December 16, 2025 08:29
@ToMESSKa ToMESSKa marked this pull request as draft December 16, 2025 08:30
@ToMESSKa ToMESSKa marked this pull request as ready for review December 16, 2025 08:30
@ToMESSKa ToMESSKa changed the title Inst UI 4811 tag rework [v12] feat(ui-tag): rework Tag Dec 16, 2025
@ToMESSKa ToMESSKa force-pushed the INSTUI-4811-tag-rework branch from 9091e5a to 0c16227 Compare December 16, 2025 08:39
@github-actions
Copy link

github-actions bot commented Dec 16, 2025 •
edited
Loading

PR Preview Action v1.6.3

🚀 View preview at
https://instructure.design/pr-preview/pr-2310/

Built to branch gh-pages at 2025-12-16 08:55 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@ToMESSKa ToMESSKa force-pushed the INSTUI-4811-tag-rework branch from 0c16227 to f4a0f10 Compare December 16, 2025 08:50
@adamlobler adamlobler requested a review from hajnaldo December 16, 2025 10:21
adamlobler
adamlobler approved these changes Dec 16, 2025
View reviewed changes
Copy link
Collaborator

@adamlobler adamlobler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I added Dorka as a reviewer since the tokens were created by her.

hajnaldo
hajnaldo approved these changes Dec 16, 2025
View reviewed changes
Copy link
Collaborator

@hajnaldo hajnaldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@balzss balzss balzss approved these changes

@adamlobler adamlobler adamlobler approved these changes

@hajnaldo hajnaldo hajnaldo approved these changes

@matyasf matyasf Awaiting requested review from matyasf

Assignees

@ToMESSKa ToMESSKa

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ToMESSKa @balzss @adamlobler @hajnaldo