[v12] feat(ui-form-field): rework FormFieldGroup #2311
+12
−107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ToMESSKa
commented
Dec 16, 2025
Comment on lines
46
to
-48
| label: 'formFieldGroup', | ||
| border: `${componentTheme.borderWidth} ${componentTheme.borderStyle} ${componentTheme.borderColor}`, | ||
| borderRadius: componentTheme.borderRadius, |
Contributor
Author
There was a problem hiding this comment.
these tokens were used for the old error style (border around all the children, newError style does not use them), but I forgot to remove them form here: #2273
ToMESSKa
commented
Dec 16, 2025
Comment on lines
38
to
+39
| const generateStyle = ( | ||
| componentTheme: FormFieldGroupTheme, | ||
| _componentTheme: FormFieldGroupTheme, |
Contributor
Author
There was a problem hiding this comment.
Both FormFieldGroup and FormFieldMessages are components that have no tokens anymore and therefore the style.ts files have no theme.
INSTUI-4871
ToMESSKa
force-pushed
the
INSTUI-4871-form-field-group-rework
branch
from
4549eee to
e2711a5
Compare
ToMESSKa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INSTUI-4871
ISSUE:
TEST PLAN: