feat(ui-table): migrate table to new theming system #2315
+130
−521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
joyenjoyer
force-pushed
the
v12_table_migration
branch
from
d62c911 to
f3f5d41
Compare
joyenjoyer
force-pushed
the
v12_table_migration
branch
from
f3f5d41 to
8b4df57
Compare
adamlobler
approved these changes
Dec 17, 2025
Collaborator
adamlobler
left a comment
adamlobler
left a comment
There was a problem hiding this comment.
I just checked it visually, it looks good on every theme 🙌
Contributor
|
The hover option in the first example does not seem to work like it does in v11. (no blue border on hover) |
Contributor
|
Can you please update the upgrade guide with the removed/renamed tokens? |
ToMESSKa
requested changes
Dec 18, 2025
Comment on lines
+38
to
41
| componentTheme: NewComponentTypes['TableRowHeader'], | ||
| props: TableRowHeaderProps | ||
| ): TableRowHeaderStyle => { | ||
| const { textAlign } = props |
Contributor
There was a problem hiding this comment.
There is a borderColor token in TableRowHeader which I don't see being used here.
Comment on lines
46
to
+49
| type TableBodyProps = TableBodyOwnProps & | ||
| WithStyleProps<TableBodyTheme, TableBodyStyle> & | ||
| OtherHTMLAttributes<TableBodyOwnProps> | ||
| WithStyleProps<null, TableBodyStyle> & { | ||
| themeOverride?: ThemeOverrideValue | ||
| } & OtherHTMLAttributes<TableBodyOwnProps> |
Contributor
There was a problem hiding this comment.
I thought adding the themeOverride param was only needed for the functional components using useStyle? see: https://instructure.slack.com/archives/G01DAT0KGKE/p1764326076310209
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes INSTUI-4810
Test:
Check if every token is used (use the excel sheet in the JIRA ticket)