Skip to content

feat(ui-color-picker): add new labelLevel prop to set heading level i… #2316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ToMESSKa wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(ui-color-picker): add new labelLevel prop to set heading level i… #2316

ToMESSKa wants to merge 1 commit into from
+79 −6

Conversation

@ToMESSKa
Copy link
Contributor

@ToMESSKa ToMESSKa commented Dec 17, 2025 •
edited
Loading

…n ColorContrast

INSTUI-4874

ISSUE:

  • the label of the ColorContrast component's heading level cannot be set, so screen reader users may have a hard time understanding the relationship between sections.

TEST PLAN:

  • add a labelLevel prop to the component. Inspect in the browser to verify the label renders as the corresponding heading element (e.g., <h1> '<h2>' etc.).
  • without the labelLevel prop, the label should be rendered as a <div>
  • there should be no visual change to the label when different labelLevel values are set (same font size, weight).
  • there should be no visual difference between a component with labelLevel set and one without it.

@ToMESSKa ToMESSKa self-assigned this Dec 17, 2025
@ToMESSKa ToMESSKa force-pushed the INSTUI-4874-allow-to-set-heading-level-on-color-contrasts-label branch from b2c8395 to 163345e Compare December 17, 2025 14:31
@github-actions
Copy link

github-actions bot commented Dec 17, 2025

PR Preview Action v1.6.3

🚀 View preview at
https://instructure.design/pr-preview/pr-2316/

Built to branch gh-pages at 2025-12-17 14:35 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@git-nandor git-nandor Awaiting requested review from git-nandor

@balzss balzss Awaiting requested review from balzss

At least 2 approving reviews are required to merge this pull request.

Assignees

@ToMESSKa ToMESSKa

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ToMESSKa