Skip to content

Conversation

@ChaoticEnigma
Copy link
Contributor

While working on a RIGOL MHO900/98 instrument class, I found that reading waveform data with a size larger than 9 digits (e.g. 500M points * 2 bytes) will encode the length of the data size in base-16. This change allowed me to read the full waveform data, although it was VERY slow on this scope.

@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.20%. Comparing base (0e26865) to head (6751b8f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #466   +/-   ##
=======================================
  Coverage   99.20%   99.20%           
=======================================
  Files          96       96           
  Lines        9648     9648           
=======================================
  Hits         9571     9571           
  Misses         77       77           
Flag Coverage Δ
unittests 99.20% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@scasagrande scasagrande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! thanks!!

@scasagrande scasagrande merged commit a4e12e8 into instrumentkit:main Jan 12, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants