-
Notifications
You must be signed in to change notification settings - Fork 0
Improve live Codex harness diagnostics #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ensure codex in-flight ends within 2.5s of completion, pick active JSONL per process, and make opencode message completion authoritative. Remove wheel passive listener warnings and align docs/tests.
Start the server on the next available port during dev and ignore stale OpenCode status events when determining in-flight state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6b28bdd9d6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| main="$(cd "$common/.." && "$pwd_bin" -P)" | ||
| cur="$("$env_bin" -u GIT_DIR -u GIT_WORK_TREE -u GIT_INDEX_FILE -u GIT_COMMON_DIR \ | ||
| "$git_bin" -C "$main" rev-parse --show-toplevel 2>/dev/null)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolve current worktree from cwd, not main repo
gwe now resolves cur using git -C "$main" rev-parse --show-toplevel, which always returns the main worktree path. As a result, even when the user is inside a secondary worktree, cur equals main and the function refuses to remove it ("refusing to remove the default worktree"). This breaks gwe for its intended use. Use the current directory (or PWD) when resolving the active worktree so secondary worktrees can be removed.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Superseded by fix/activity-state; live harness changes consolidated. |
Summary
Testing
Ensure you read the contribution guide before submitting a commit and follow the exact guidelines.