Adding test scenario for crash MSR updates #636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyao1
reviewed
Nov 25, 2025
src/migtd/src/bin/migtd/main.rs
Outdated
|
|
||
| // Test scenario for crash MSR updates | ||
| #[cfg(all(feature = "test-crashmsr", feature = "vmcall-raw"))] | ||
| panic_with_guest_crash_reg_report(0xFF, b"Test Crash MSR updates"); |
Contributor
There was a problem hiding this comment.
I have concern to put test code directly into the production code.
Maybe a better way is to create a test-payload and put all test code there.
Contributor
Author
There was a problem hiding this comment.
sounds good jiewen, I have moved them to test framework. Please let me know if that works.
Signed-off-by: Gudaram, Meghana <meghana.gudaram@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding test framework for crash MSR update feature