Skip to content

Conversation

@agokarn
Copy link
Contributor

@agokarn agokarn commented Dec 16, 2025

This branch implements unified logging infrastructure for MigTD with support for structured, per-migration-request logging.

The PR addresses issues #571 and has the following changes -

  1. Conditionally initializes td_logger OR vmm_logger based on feature flag
  2. Ensures all subsequent logs are tagged with correct migration request ID
  3. Support for key-value pairs in log messages
  4. Existing log calls work as-is

@agokarn agokarn requested a review from jyao1 as a code owner December 16, 2025 20:53
@agokarn agokarn force-pushed the user/arthig/enable-unified-logging branch from e6c6518 to 4485086 Compare December 16, 2025 23:21
	modified:   src/migtd/src/bin/migtd/main.rs
	modified:   src/migtd/src/migration/logging.rs
	modified:   src/migtd/src/migration/session.rs
	modified:   src/migtd/src/ratls/server_client.rs

Add init_vmm_logger

	modified:   src/migtd/src/bin/migtd/main.rs
	modified:   src/migtd/src/migration/logging.rs
	modified:   src/migtd/src/migration/session.rs
	modified:   src/migtd/src/ratls/server_client.rs

Fix incorrect log format.

Remove unneccesary changes.

	modified:   src/migtd/src/bin/migtd/main.rs
	modified:   src/migtd/src/migration/logging.rs
	modified:   src/migtd/src/migration/session.rs

Bug fixes

	modified:   src/migtd/src/bin/migtd/main.rs
	modified:   src/migtd/src/migration/logging.rs
	modified:   src/migtd/src/migration/session.rs

release_max_level_off not needed anymore.

	modified:   src/migtd/Cargo.toml
	modified:   src/migtd/src/bin/migtd/main.rs
	modified:   src/migtd/src/migration/logging.rs
	modified:   src/migtd/src/migration/session.rs
@agokarn agokarn force-pushed the user/arthig/enable-unified-logging branch from 4f53a45 to 201c16b Compare December 16, 2025 23:41
@jyao1
Copy link
Contributor

jyao1 commented Dec 17, 2025

@mgudaram , please review as well.

@mgudaram
Copy link
Contributor

sure Jiewen, I will go over the changes.

3 => LevelFilter::Info,
4 => LevelFilter::Debug,
5 => LevelFilter::Trace,
_ => LevelFilter::Info, // Handle cases where the u8 doesn't map to a valid Level
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, 0 will match Info?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants