Clean up error messages in log #588
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on improving error handling and logging in both the configuration and reporting commands. The main changes enhance how errors are aggregated and surfaced to users, and adjust logging severity for certain non-critical issues.
Error handling improvements in configuration:
setOnTarget, so that all errors are reported together instead of failing fast. The aggregated error messages are sent back through thechannelErrorchannel. [1] [2] [3]runCmdfunction to collect and check for errors from all targets, printing and logging any errors after all processing is complete, and ensuring the command exits with an error if any occurred. [1] [2]Logging severity adjustments:
ErrororInfotoWarnindimm.goandtelemetry_tables.goto better reflect that these situations are not always critical failures, such as unrecognized DIMM size formats or missing telemetry data on some platforms. [1] [2] [3] [4]Robustness in telemetry reporting:
getMetricAverageto return an empty string if there are no fields to average, preventing potential panics or misleading results.