Add intel-ipu-fw-info as a standalone tool #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrjohannchang
force-pushed
the
pr-ipu-fw-info-refactoring
branch
from
167a15e to
305e667
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tool
intel-ipu-fw-infois dramatically refactored against the Pythonic conventions based on commands https://github.com/intel/ipu6-camera-bins/blob/main/ipu6/lib/firmware/intel/ipu_fw_info.py and https://github.com/intel/ipu6-camera-bins/blob/main/ipu6ep/lib/firmware/intel/ipu_fw_info.py.The above two commands are pretty much identical. The only difference between them is only the latter one contains the production key of Alder Lake. We should unify them as they shouldn't be split into two different independent commands only because they contain different data.