config/linux/ipu6: ov01a1s configs: Adjust for new 1288x800 ov01a1s output size #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ernel driver output size There is a patch series pending upstream: https://lore.kernel.org/linux-media/20251014174033.20534-1-hansg@kernel.org/ To add ov01a1s support to the mainline kernel. The mainline support will have a slightly different output-size with a maximum output width of 1288 as the mainline code keeps a 4x4 border reserved to be able to shift the window around to keep the Bayer pattern unchanged when doing flipping. And with the mainline driver the output height must be a multiple of 4 because the RGBI Bayer patern on the ov01a1s sensor repeats every 4 lines. There also is a pending pull-request to change the output-size of the ov01a1s driver in intel-ipu6-drivers to match the mainline driver: intel/ipu6-drivers#395 This commit adjusts the graph_settings_ov01a1s.xml and ov01a1s-uf.xml config files to work with the new 1288x800 output size. Signed-off-by: Hans de Goede <hansg@kernel.org>
hao-yao
reviewed
Nov 13, 2025
Contributor
hao-yao
left a comment
hao-yao
left a comment
There was a problem hiding this comment.
@jwrdegoede Thank you Hans, but I still have some comments on this change. By the way, do you think whether does ipu6ep need this change? I'm not sure if there is a device using ov01a1s + Alder/Raptor Lake.
| <stream2mmio> | ||
| <input width="1296" height="800" top="1" left="0" bottom="1" right="0" /> | ||
| <output width="1296" height="798" top="0" left="0" bottom="0" right="0" /> | ||
| <input width="1288" height="800" top="1" left="0" bottom="1" right="0" /> |
Contributor
There was a problem hiding this comment.
Maybe we need to set input & output both as 1288, 800, 0, 0, 0, 0?
Contributor
Author
There was a problem hiding this comment.
No, changing the top value will shift the Bayer pattern leading to wrong colors.
Contributor
Author
I'm not aware of any Alder/Raptor Lake hardware using the ov01a1s. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a patch series pending upstream:
https://lore.kernel.org/linux-media/20251014174033.20534-1-hansg@kernel.org/
To add ov01a1s support to the mainline kernel. The mainline support will have a slightly different output-size with a maximum output width of 1288 as the mainline code keeps a 4x4 border reserved to be able to shift the window around to keep the Bayer pattern unchanged when doing flipping.
And with the mainline driver the output height must be a multiple of 4 because the RGBI Bayer patern on the ov01a1s sensor repeats every 4 lines.
There also is a pending pull-request to change the output-size of the ov01a1s driver in intel-ipu6-drivers to match the mainline driver:
intel/ipu6-drivers#395
This commit adjusts the graph_settings_ov01a1s.xml and ov01a1s-uf.xml config files to work with the new 1288x800 output size.