Skip to content

media: i2c: Assign INTC113C HID to ISX031 for upstream compliance #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gohweikh wants to merge 1 commit into
base: iotg_ipu6
Choose a base branch
from
+1 −1
Open

media: i2c: Assign INTC113C HID to ISX031 for upstream compliance #400

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion drivers/media/i2c/isx031.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1031,7 +1031,7 @@ static const struct isx031_info isx031_mipi_info = {
};

static const struct acpi_device_id isx031_acpi_ids[] = {
{ "INTC3031", (kernel_ulong_t)&isx031_mipi_info },
{ "INTC113C", (kernel_ulong_t)&isx031_mipi_info },
Copy link

@123456987789 123456987789 Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls use INTC1031, keep consistent with upstream gmsl driver.
upstream gmsl driver patch in ipu7-driver

Copy link
Author

@gohweikh gohweikh Dec 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

INTC113C is our newly registered HID under goto.intel.com/acpi, approved in WW49. Need to replace existing unofficial INTC1031 HID, and all future upstream effort on ISX031 will be aligned to this HID.

FYI, INTC1031 HID was taken In Intel ACPI HID allocation list.

CC will update this change in his PR upstream gmsl driver patch in ipu7-driver

Copy link
Contributor

@hao-yao hao-yao Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

INTC113C is our newly registered HID under goto.intel.com/acpi, approved in WW49. Need to replace existing unofficial INTC1031 HID, and all future upstream effort on ISX031 will be aligned to this HID.

CC will update this in his PR upstream gmsl driver patch in ipu7-driver

Please settle down the HID first, as the ACPI table change may not applied on devices which are already delivered to customers.

{}
};

Expand Down