[Media Decode] not reduce the slice number when destroy slice data buffer #1978
+2
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iceDataBuffer sometimes, app call vaDestoryBuffer for VASliceDataBufferType in middle of one frame execution. for example: there are two VASliceDataBufferType for one frame. after first VASliceDataBufferType was created. then destroy one VASliceDataBufferType of last frame , then create second slice for current frame, it will cause problem. the rootcause is :media driver try to optimize the bistream combination, so it allocate one buffer for mulitple slice data. then these slice data just get the offset and were filled into one bistream buffer. this method reduce one combination copy. Signed-off-by: Carl Zhang <carl.zhang@intel.com>
XinfengZhang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…iceDataBuffer
sometimes, app call vaDestoryBuffer for VASliceDataBufferType in middle of one frame execution. for example: there are two VASliceDataBufferType for one frame. after first VASliceDataBufferType was created. then destroy one VASliceDataBufferType of last frame , then create second slice for current frame, it will cause problem.
the rootcause is :media driver try to optimize the bistream combination, so it allocate one buffer for mulitple slice data. then these slice data just get the offset and were filled into one bistream buffer. this method reduce one combination copy.