Skip to content

Converter script update #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edwarddavidbaker merged 2 commits into from
Dec 17, 2025
Merged

Converter script update #353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5d1f07
Added DMR to platform config file
calebbiggers Dec 2, 2025
dc7e493
Updated perf converter error handling
calebbiggers Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions scripts/config/platform_config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,5 +232,14 @@
"CoreType":"E-core",
"IsHybrid":true,
"DefaultLevel":2
},
{
"Name": "Diamond Rapids",
"ShortName": "DMR",
"FileName": "DiamondRapids",
"Core": "PantherCove",
"CoreType": "P-core",
"IsHybrid": false,
"DefaultLevel": 2
}
]
6 changes: 4 additions & 2 deletions scripts/perf_format_converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
#
# perf_format_converter.py
# -i (--finput) <Path to Input File> (optional)
# -t (--tma) <Enable TMA conversion> (optional)
#
# ASSUMES: That the script is being run in the scripts folder of the repo and that all files
# are JSON format
Expand Down Expand Up @@ -64,7 +65,7 @@ def apply_extra_properties(self, platform):
INPUT_DIR_PATH = Path("./inputs/")
OUTPUT_DIR_PATH = Path("./outputs/")

# Fields to always display event if empty
# Fields to always display even if empty
PERSISTENT_FIELDS = ["MetricGroup", "BriefDescription"]

# Operators
Expand Down Expand Up @@ -124,6 +125,7 @@ def convert_file(file_path: Path, output_tma: bool):
# Convert the dictionary to list of Perf format metric objects
perf_metrics = format_converter.convert_to_perf_metrics(platform, output_tma)
if not perf_metrics:
print(f"[ERROR] - Could not convert metrics or file is empty: <{str(file_path.name)}> Skipping...")
return

# Get the output file
Expand All @@ -145,7 +147,7 @@ def get_args():
# Arguments
parser.add_argument("-i", "--finput", type=Path,
help="Path of input json file", required=False)
parser.add_argument("-t", "--tma", type=bool,
parser.add_argument("-t", "--tma", type=bool, default=False,
help="Output TMA metrics [true/false]", required=False)

# Get arguments
Expand Down