Optimize mah related build option #2462
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes math-related compiler flags for GNU compiler builds by simplifying floating-point behavior control. The change replaces four specific floating-point flags with two more comprehensive options.
Key Changes:
- Consolidated multiple floating-point flags into
-fno-fast-mathand-fmafor simpler and more predictable floating-point behavior - Maintained strict floating-point semantics while enabling fused multiply-add optimizations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change is a revision of the math-related compiler flags to better control floating-point behavior.
Build flag changes for GNU compiler:
-fhonor-nans,-fhonor-infinities,-fno-associative-math,-fno-approx-func) and replaced them with-fno-fast-mathand-fmain theSYCL_KERNEL_OPTIONSto adjust floating-point operation handling and enable fused multiply-add instructions.