Enhance logging configuration.#1692
Merged
BalaBalaYi merged 2 commits intointelligent-machine-learning:masterfrom Feb 4, 2026
Merged
Enhance logging configuration.#1692BalaBalaYi merged 2 commits intointelligent-machine-learning:masterfrom
BalaBalaYi merged 2 commits intointelligent-machine-learning:masterfrom
Conversation
BalaBalaYi
requested review from
bikemechanic,
majieyue,
samplise,
way-zer and
workingloong
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1692 +/- ##
==========================================
- Coverage 80.43% 80.42% -0.02%
==========================================
Files 228 228
Lines 22960 22972 +12
==========================================
+ Hits 18469 18476 +7
- Misses 4491 4496 +5 ☔ View full report in Codecov by Sentry. |
way-zer
approved these changes
Feb 3, 2026
BalaBalaYi
merged commit d604c7b
into
intelligent-machine-learning:master
11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
New 2 params for logging configuration:
DLROVER_LOG_ROTATE_MAX_BYTES
DLROVER_LOG_ROTATE_BACKUP_COUNT
Why are the changes needed?
Enhance logging setting by envs.
Does this PR introduce any user-facing change?
logging.md
How was this patch tested?
UT