Open
Conversation
tt
reviewed
Sep 30, 2025
|
|
||
| ### Removed | ||
| ### Changed | ||
| - Update minimum required version of sinatra from 2 to 3 (https://github.com/interagent/pliny/pull/370) |
Contributor
There was a problem hiding this comment.
Why do we want to default to a non-latest major version?
Aiming for compatibility is fine but if you start something new, starting with the minimum amount of future maintenance work seems ideal.
I don't think this would be a breaking change so we can also address that later.
tt
approved these changes
Oct 3, 2025
beanieboi
force-pushed
the
bf/prep-2.0
branch
from
be81190 to
ae52c50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to 1.3 (see https://github.com/interagent/pliny/tree/bf/v1.3.0) which only contains a new Sentry error reporter and is compatible to 1.x. This releases 2.0 with the latest changes from
mainwhich has backwards incompatible changes in addition to the Sentry reporter