Skip to content

fix(ci/deploy): run on contributors PR#528

Open
DarianM wants to merge 2 commits intomainfrom
ok-to-deploy-issue-comment
Open

fix(ci/deploy): run on contributors PR#528
DarianM wants to merge 2 commits intomainfrom
ok-to-deploy-issue-comment

Conversation

@DarianM
Copy link
Member

@DarianM DarianM commented Jan 22, 2026

Context

Follow-up #373

Solves the issue where fork PRs could not deploy previews via comment due to missing repo access.

Note to reviewer: workflow needs to exist on default branch (main) to run

@github-actions
Copy link

github-actions bot commented Jan 22, 2026

Deployment results

Worker Alias URL Outcome
API - e1bd7333 success
CDN - 18ae5990 success
App - 064537a9 success

Logs #21283272539

@DarianM DarianM requested a review from sidvishnoi January 22, 2026 21:15
DarianM

This comment was marked as outdated.

@DarianM DarianM removed the request for review from sidvishnoi January 23, 2026 09:56
@DarianM DarianM requested a review from sidvishnoi January 23, 2026 10:41
Comment on lines 37 to +38
with:
# Ensures we checkout the PR head commit for both pull_request and pull_request_review events
ref: ${{ github.event.pull_request.head.sha || github.sha }}
# Fetches the full git history, both base and head SHAs are available
fetch-depth: 0
fetch-depth: 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can use defaults?

username: event.comment.user.login
});

const isAuthorized = ['admin', 'maintain', 'write'].includes(permission.permission);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use isAllowedAuthor somehow? Maybe with a different API call?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we fetch the comment by ID, can get author_association
https://api.github.com/repos/interledger/publisher-tools/issues/comments/3799339719

@sidvishnoi
Copy link
Member

ok-to-deploy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants