refactor(api): allows banner profile saving in the new format#531
Draft
refactor(api): allows banner profile saving in the new format#531
Conversation
Deployment results
Logs #21912168249 |
sidvishnoi
reviewed
Jan 27, 2026
Comment on lines
+51
to
+52
| const legacy = | ||
| await storage.getLegacyJson<ConfigVersions>(walletAddress) |
Member
There was a problem hiding this comment.
Do we need to handle non-404 errors similar to above here as well?
sidvishnoi
reviewed
Jan 27, 2026
| return TOOLS.includes(type as Tool) | ||
| } | ||
|
|
||
| /** @legacy - no longer used */ |
Member
There was a problem hiding this comment.
Can be removed if no longer used?
sidvishnoi
reviewed
Jan 27, 2026
| const DEV_CDN_URL = 'http://localhost:5173' | ||
| const DEV_FRONTEND_URL = 'http://localhost:3000/tools/' // contains trailing slash and pathname. | ||
| const DEV_AWS_PREFIX = '20250717-dev' | ||
| const DEV_AWS_PREFIX = '20260126-dev' |
Member
There was a problem hiding this comment.
Don't forget to set on in Actions variables as well.
DarianM
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #511