refactor(frontend): allow banner tool to use profile format#561
Open
refactor(frontend): allow banner tool to use profile format#561
Conversation
Deployment results
Logs #21946642677 |
DarianM
commented
Feb 12, 2026
DarianM
commented
Feb 12, 2026
| useEffect(() => { | ||
| if (bannerContainerRef.current && isLoaded) { | ||
| if (bannerElementRef.current) { | ||
| bannerElementRef.current.config = bannerConfig |
Member
Author
There was a problem hiding this comment.
I will revert the name back to config as we also pass the cdnUrl alongside profile, so this is not really profile only...
sidvishnoi
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #511
Context
Part of the ongoing effort to deprecate
ElementConfigTypein favor of typed tool profilesBannerProfilein the new format