fix: redesign admin ui #3793
fix: redesign admin ui #3793
Conversation
✅ Deploy Preview for brilliant-pasca-3e80ec ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mkurapov
left a comment
mkurapov
left a comment
There was a problem hiding this comment.
Looking good! I will ask the team for further reviews
| @@ -23,6 +33,60 @@ import type { ZodFieldErrors } from '~/shared/types' | |||
| import { capitalize, formatAmount } from '~/shared/utils' | |||
There was a problem hiding this comment.
| import { capitalize, formatAmount } from '~/shared/utils' | |
| import { formatAmount } from '~/shared/utils' |
| </Flex> | ||
| </Flex> | ||
| <hr /> | ||
| in <Flex direction='column' gap='4'> |
There was a problem hiding this comment.
| in <Flex direction='column' gap='4'> | |
| <Flex direction='column' gap='4'> |
| className='absolute inset-0 bg-cover bg-center' | ||
| style={{ backgroundImage: `url(${bgUrl})` }} | ||
| /> |
There was a problem hiding this comment.
I think we can just keep the plain background
| className={`pt-20 md:pt-0 flex ${displaySidebar ? 'md:pl-60' : ''} flex-1 flex-col`} | ||
| > | ||
| <main className='pb-8 px-4'> | ||
| <body className='h-full text-tealish bg-diagonal'> |
There was a problem hiding this comment.
| <body className='h-full text-tealish bg-diagonal'> | |
| <body className='h-full text-tealish'> |
Just personal preference :)
BlairCurrey
left a comment
BlairCurrey
left a comment
There was a problem hiding this comment.
Looks great overall. Much improved.
I will also +1 Max's suggestion on the background #3793 (comment)
There was a problem hiding this comment.
Not just specific to this file, but noticed it here.
If you search for <h1 or 2,3,4 you see we still use the raw html headings in places. Should we make all of those use radix <Heading>?
| <Card className='max-w-3xl'> | ||
| <Flex direction='column' gap='4'> | ||
| <Flex align='center' justify='between' gap='3' wrap='wrap'> | ||
| <Text className='rt-Text rt-r-size-2 rt-r-weight-medium uppercase tracking-wide text-gray-600 font-semibold'> |
There was a problem hiding this comment.
What do you think about making these section titles <Heading>s? Maybe a small thing but I think it's more semantic and matches what it was previously.
| className='h-full bg-polkadot bg-cover bg-no-repeat bg-center bg-fixed' | ||
| className='h-full' |
There was a problem hiding this comment.
Feels like it's missing something without the polka dot background.
Needs something IMO. bg-diagonal almost feels too light because the content is pretty much just in the white part.
Please go to the
Previewtab and select the appropriate sub-template: