Skip to content

Conversation

@njlie
Copy link
Contributor

@njlie njlie commented Jan 23, 2026

Changes proposed in this pull request

  • Updates the payload of the incoming_payment.partial_payment_received webhook.
    • Nests all partial payment information inside a partialPayment field.
    • Adds a uuid for each partial payment and the amount of that partial payment.
  • Update webhooks.yaml specfication

Context

Fixes RAF-1209.

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Make sure that all checks pass
  • Bruno collection updated (if necessary)
  • Documentation issue created with user-docs label (if necessary)
  • OpenAPI specs updated (if necessary)

@netlify
Copy link

netlify bot commented Jan 23, 2026

Deploy Preview for brilliant-pasca-3e80ec canceled.

Name Link
🔨 Latest commit 7819510
🔍 Latest deploy log https://app.netlify.com/projects/brilliant-pasca-3e80ec/deploys/69792c9df1c2730008142b0b

@github-actions github-actions bot added type: tests Testing related pkg: backend Changes in the backend package. type: source Changes business logic labels Jan 23, 2026
@github-actions
Copy link

github-actions bot commented Jan 23, 2026

🚀 Performance Test Results

Test Configuration:

  • VUs: 4
  • Duration: 1m0s

Test Metrics:

  • Requests/s: 42.31
  • Iterations/s: 14.13
  • Failed Requests: 0.00% (0 of 2545)
📜 Logs

> performance@1.0.0 run-tests:testenv /home/runner/work/rafiki/rafiki/test/performance
> ./scripts/run-tests.sh -e test "-k" "-q" "--vus" "4" "--duration" "1m"

Cloud Nine GraphQL API is up: http://localhost:3101/graphql
Cloud Nine Wallet Address is up: http://localhost:3100/
Happy Life Bank Address is up: http://localhost:4100/
cloud-nine-wallet-test-backend already set
cloud-nine-wallet-test-auth already set
happy-life-bank-test-backend already set
happy-life-bank-test-auth already set
     data_received..................: 919 kB 15 kB/s
     data_sent......................: 2.0 MB 33 kB/s
     http_req_blocked...............: avg=6.81µs   min=1.83µs   med=5.29µs   max=885.57µs p(90)=6.45µs   p(95)=7.16µs  
     http_req_connecting............: avg=465ns    min=0s       med=0s       max=643.98µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=93.88ms  min=6.64ms   med=76.56ms  max=625.87ms p(90)=164.47ms p(95)=185.73ms
       { expected_response:true }...: avg=93.88ms  min=6.64ms   med=76.56ms  max=625.87ms p(90)=164.47ms p(95)=185.73ms
     http_req_failed................: 0.00%  ✓ 0         ✗ 2545
     http_req_receiving.............: avg=91.04µs  min=26.94µs  med=80.64µs  max=1.67ms   p(90)=120.93µs p(95)=154.5µs 
     http_req_sending...............: avg=37.28µs  min=11.06µs  med=28.22µs  max=4.58ms   p(90)=39.33µs  p(95)=51.53µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=93.75ms  min=6.51ms   med=76.4ms   max=625.76ms p(90)=164.25ms p(95)=185.6ms 
     http_reqs......................: 2545   42.307904/s
     iteration_duration.............: avg=282.73ms min=182.55ms med=272.31ms max=1.13s    p(90)=342.51ms p(95)=382.88ms
     iterations.....................: 850    14.130341/s
     vus............................: 4      min=4       max=4 
     vus_max........................: 4      min=4       max=4 

@njlie njlie requested review from mkurapov and sanducb January 23, 2026 20:37
@njlie njlie marked this pull request as ready for review January 23, 2026 20:37
: dataToTransmit
...incomingPayment.toData(value),
partialPayment: {
uuid: partialPaymentId,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uuid: partialPaymentId,
id: partialPaymentId,

@njlie njlie force-pushed the nl/raf-1209/update-partial-payment-webhook branch from 3369f2a to 7819510 Compare January 27, 2026 21:22
@njlie njlie changed the base branch from main to feature/encrypted-data-exchange January 27, 2026 21:22
@njlie njlie requested a review from mkurapov January 28, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: backend Changes in the backend package. type: source Changes business logic type: tests Testing related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants