Create config subdirectories for dev and prod#845
Open
martinburchell wants to merge 3 commits intointermine:devfrom
Open
Create config subdirectories for dev and prod#845martinburchell wants to merge 3 commits intointermine:devfrom
martinburchell wants to merge 3 commits intointermine:devfrom
Conversation
Member
Author
|
I don't think the CircleCI failures are down to anything I've done. I tried fixing the missing Ubuntu image but there were failures further down the line. I'll stop there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
.gitignorefile will ignore files likeconfig/dev/config.ednandconfig/prod/config.ednbut thedevandprodsubdirectories don't exist in version control. This looks like an oversight.This change ensures these directories are in git by including a
README.mdin each.This change will also ignore Emacs backup files