Allow download empty files #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexisMora
reviewed
Dec 23, 2025
| updateCredentials(token, newToken); | ||
|
|
||
| return right([token, newToken]); | ||
| return right([token ?? '', newToken]); |
AlexisMora
reviewed
Dec 23, 2025
src/apps/main/auth/service.ts
Outdated
| const isSafeStorageAvailable = safeStorage.isEncryptionAvailable(); | ||
|
|
||
| const token = isSafeStorageAvailable ? ecnryptToken(bearerToken) : bearerToken; | ||
| const token = isSafeStorageAvailable && bearerToken ? ecnryptToken(bearerToken) : bearerToken; |
There was a problem hiding this comment.
Whats the reason behind this change? if you make it optional then we can return an undefined value
AlexisMora
reviewed
Dec 23, 2025
src/context/storage/StorageFiles/application/offline/CacheStorageFile.ts
Outdated
Show resolved
Hide resolved
…djust updateCredentials to allow optional bearerToken
…fresh-token test to reflect new structure
…tly handle time calculations
…o correctly handle time calculations" This reverts commit 24eb2c3.
…tly handle time calculations
…r consistency and clarity
AlexisMora
force-pushed
the
feat/allow-download-empty-files
branch
from
3016df0 to
e380bdd
Compare
|
AlexisMora
approved these changes
Dec 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is Changed / Added
Why