[PB-5239]: add confirmation dialog for deleting backups #1792
+73
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a confirmation dialog before deleting items in the backups view to prevent accidental deletions. Refactors delete logic to handle both file viewer and list contexts.
Deploying drive-web with
|
| Latest commit: |
b088628
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://34dcc92a.drive-web.pages.dev |
| Branch Preview URL: | https://fix-backups-confirmation-mod.drive-web.pages.dev |
larryrider
reviewed
Dec 24, 2025
| } | ||
| }; | ||
|
|
||
| const onDeleteSelectedItems = async () => { |
Contributor
There was a problem hiding this comment.
I think this function could be a little "weird" with the return inside the if
Maybe its better this way wdyt?:
if (isFileViewerOpen) {
await performDeleteItems(selectedItems);
} else {
openDeleteItemsDialog(selectedItems);
}
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces a confirmation dialog before deleting items in the backups view to prevent accidental deletions. Refactors delete logic to handle both file viewer and list contexts.
Related Issues
Related Pull Requests
Checklist
Testing Process
Additional Notes