Skip to content

Add check for renaming tag to already used tag. #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jwr1 merged 1 commit into from
Dec 11, 2025
Merged

Add check for renaming tag to already used tag. #331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/l10n/app_en.arb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
"refreshAuth": "Refresh login",
"totpToken": "TOTP Token (if needed)",
"cancel": "Cancel",
"okay": "Okay",
"rename": "Rename",
"replace": "Replace",
"continue_": "Continue",
Expand Down
34 changes: 26 additions & 8 deletions lib/src/widgets/tags/tag_editor.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,14 +111,32 @@ class _TagEditorState extends State<TagEditor> {
padding: const EdgeInsets.only(right: 8),
child: FilledButton(
onPressed: () async {
final tag = await ac.setTag(
Tag(
id: widget.tag.id,
tag: _tagController.text,
backgroundColor: _backgroundColor,
textColor: _textColor,
),
);
Tag tag;
try {
tag = await ac.setTag(
Tag(
id: widget.tag.id,
tag: _tagController.text,
backgroundColor: _backgroundColor,
textColor: _textColor,
),
);
} catch (err) {
if (!context.mounted) return;
await showDialog(
context: context,
builder: (context) => AlertDialog(
title: Text(l(context).tags_exist),
actions: [
OutlinedButton(
onPressed: () => Navigator.pop(context),
child: Text(l(context).okay),
),
],
),
);
return;
}
widget.onUpdate(tag);
if (!context.mounted) return;
Navigator.pop(context);
Expand Down