Skip to content

Conversation

@the-glu
Copy link
Contributor

@the-glu the-glu commented Jan 14, 2026

Fix #1221

Switch back to optional instead of | None for ImplicitDict.

Use Optional for ImplicitDict, this has two advantages:

NB: The switch had to be done manually on the codebase, I may have miss some instances

Copy link
Member

@BenjaminPelletier BenjaminPelletier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof, thanks for biting the bullet on making these changes semi-manually

@BenjaminPelletier BenjaminPelletier merged commit a8adabe into interuss:main Jan 14, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not replace Optional with | None in ImplicitDict fields

2 participants