[tooling] Use optional in ImplicitDicts #1314
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1221
Switch back to optional instead of
| NoneforImplicitDict.Use
OptionalforImplicitDict, this has two advantages:OptionalImplicitDictswitch to a "better" implementation (see Do not replace Optional with| Nonein ImplicitDict fields #1221 comments), we can expect it to expose the newOptionalhere and don't have to do any change.NB: The switch had to be done manually on the codebase, I may have miss some instances