Skip to content

Conversation

@Chemaclass
Copy link
Contributor

@Chemaclass Chemaclass commented Nov 10, 2021

Original idea by @alexandrajulius 🙌

🛠 Manual steps

$ ws install

This will create an empty file .bash_history in /.my127ws and it will mount your local bash history to that file.
Therefore, after exiting and entering the console container again, you will still have your bash history available.

🤔 Open questions

Maybe does it make sense to add this mounting to the _base console template? Or all other as well?

  • src/_base/_twig/docker-compose.yml/service/console.yml.twig

Answer: #635 ☝️

@kierenevans
Copy link
Contributor

Thank you for porting it from the other repo but #635 is already here 🥳

@kierenevans
Copy link
Contributor

Though actually, that PR doesn't cover the src/spryker/_twig/docker-compose.yml/service/console.yml.twig file, so both PRs will be needed or combined

@Chemaclass
Copy link
Contributor Author

@kierenevans jap, #635 is updating _base and this current PR is updating spryker.

@alexandrajulius
Copy link

I wasn't aware, we need the mounting in spryker too?
I tested the changes in #635 for only base and it works fine on spryker.
I can add the change to #635 if this is required @kierenevans ?

@kierenevans
Copy link
Contributor

_base is the base layer, spryker is layered on top of that so need to apply to every console.yml.twig if there's an override in the framework-specific directories.

@Chemaclass
Copy link
Contributor Author

I close this PR in favor of the one from @alexandrajulius #635

@Chemaclass Chemaclass closed this Nov 11, 2021
@Chemaclass Chemaclass deleted the feature/mount-bash-history-in-harness branch November 11, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants