Skip to content
This repository was archived by the owner on Jul 20, 2018. It is now read-only.

Conversation

@AlvYuste
Copy link

@AlvYuste AlvYuste commented Sep 4, 2017

Added hook to work with ionic-plugin-deeplinks in iOS. It adds the associated domain specified to the plugin.

For instance, having:

<plugin name="ionic-plugin-deeplinks" spec="^1.0.15">
    <variable name="URL_SCHEME" value="mycustomschema" />
    <variable name="DEEPLINK_SCHEME" value="https" />
    <variable name="DEEPLINK_HOST" value="mycustomdomain.com" />
</plugin>

If you include the hook:

<platform name="ios">
    <hook type="after_prepare" src="package-hooks/ios_deeplinks_entitlement.js" />
    ...
</platform>

The XCode project will have the domain applinks:mycustomdomain.com associated.

This solves

Looking forward to a review @dwieeb.

Credits for @lpg-mac:
https://gist.github.com/lpg-mac/02abd3a77f1c880e8f9d59af4423c5af

Thanks!

@mlynch
Copy link

mlynch commented Sep 19, 2017

Hey all, just wanted to share some changes that are happening with the need for this. The new Ionic Pro Package feature doesn't require hooks to be added in here. Just install the plugin, and if there are hooks, they will Just Work.

As such, I probably won't merge this just to avoid any issues with current Cloud Package. I strongly suggest taking a look at Pro which is where Ionic is going and the package service for Pro is a lot better and improving rapidly. Here's a guide on migrating over:

http://ionicframework.com/docs/pro/migration/package.html

@mlynch mlynch closed this Sep 19, 2017
@mlynch mlynch reopened this Sep 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants