This repository was archived by the owner on Apr 1, 2022. It is now read-only.
Updating order of middleware & improving types#2
Open
corysmc wants to merge 4 commits intoionic-team:masterfrom
Open
Updating order of middleware & improving types#2corysmc wants to merge 4 commits intoionic-team:masterfrom
corysmc wants to merge 4 commits intoionic-team:masterfrom
Conversation
Changing the order fixes an “undefined action” that get’s logged - see this issue reduxjs/redux-thunk#91
Author
|
@mlynch this PR will help new stencil-redux devs. I've updated the order of middleware (same as this PR), and made some simple changes to improve the default typings |
This reverts commit 2840950.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing the order fixes an “undefined action” that get’s logged - see
this issue
reduxjs/redux-thunk#91