routing: un-deprecate legacy delegated routing API#1075
Closed
routing: un-deprecate legacy delegated routing API#1075
Conversation
Since [IPIP-378](ipfs/specs#378) is not moving forward, the legacy API is not deprecated because there nothing to replace it.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1075 +/- ##
=======================================
Coverage 61.10% 61.11%
=======================================
Files 264 264
Lines 26215 26215
=======================================
+ Hits 16019 16021 +2
Misses 8519 8519
+ Partials 1677 1675 -2
... and 12 files with indirect coverage changes 🚀 New features to boost your workflow:
|
lidel
reviewed
Dec 2, 2025
Member
There was a problem hiding this comment.
After discussing with @aschmahmann and @gammazero we decided to keep this deprecated.
My thinking is: close this, and instead update godoc in #1076 to reference more relevant IPIP.
Thoughts?
Contributor
Author
... Closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since IPIP-378 is not moving forward, the legacy API is not deprecated because there nothing to replace it.