Use PUT as method to insert provider records#35
Conversation
|
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
Change the implementation of HTTP delegated routing provider records to match the IPIP-337 specification. The specification was changed to use `PUT`. Close request body after decoding when handling provide.
33d2940 to
4fd6521
Compare
|
AFAIT you removed the Is it because you plan to open a new IPIP ? What is the source of truth here ? |
correct. the put hasn't been deferred from 337, but that doesn't mean we aren't working towards it and I believe the convention is that code comes before spec. |
|
As soon as IPIP-337 is merged PR to add |
* feat: use PublishOptions for publishing IPNS records * chore: interface-go-ipfs-core v0.9.0 Co-authored-by: Marcin Rataj <lidel@lidel.org> This commit was moved from ipfs/go-namesys@3f6313c
Change the implementation of HTTP delegated routing provider records to match the IPIP-337 specification. The specification was changed to use
PUT.Close request body after decoding when handling provide.