This repository was archived by the owner on Jun 20, 2023. It is now read-only.
feat: use PublishOptions for publishing IPNS records#35
Merged
Conversation
hacdias
force-pushed
the
feat/publish-options
branch
4 times, most recently
from
6436cc9 to
eeacbd1
Compare
6 tasks
hacdias
force-pushed
the
feat/publish-options
branch
from
eeacbd1 to
6b648ff
Compare
hacdias
force-pushed
the
feat/publish-options
branch
from
6b648ff to
75d18a4
Compare
hacdias
force-pushed
the
feat/publish-options
branch
from
75d18a4 to
5fa05c8
Compare
lidel
approved these changes
Jan 24, 2023
Member
lidel
left a comment
lidel
left a comment
There was a problem hiding this comment.
Merging, so we can bubble up to ipfs/kubo#9471
lidel
reviewed
Jan 24, 2023
Comment on lines
+292
to
+297
| // This is a bit hacky. We do this because the EOL is based on the current | ||
| // time, but also needed in the end of the function. Therefore, we parse | ||
| // the options immediately and add an option PublishWithEOL with the EOL | ||
| // calculated in this moment. | ||
| publishOpts := opts.ProcessPublishOptions(options) | ||
| options = append(options, opts.PublishWithEOL(publishOpts.EOL)) |
Member
There was a problem hiding this comment.
💭 I think this is still way better than the old context hackery, and quite futrure-proof (allows us to add more opts if needed, without having to change public API)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires ipfs/interface-go-ipfs-core#94:
This PR allows us to fix
--ttlflag during IPNS record publishing.See ipfs/kubo#9471