coreapi/unixfs: in /add, don't setup a MFS root with a mock#10183
Draft
MichaelMure wants to merge 2 commits intoipfs:masterfrom
Draft
coreapi/unixfs: in /add, don't setup a MFS root with a mock#10183MichaelMure wants to merge 2 commits intoipfs:masterfrom
MichaelMure wants to merge 2 commits intoipfs:masterfrom
Conversation
It seems to me that this section of the code is unnecessary as a similar setup would be done [in the adder](https://github.com/ipfs/kubo/blob/a7c65184976e8717ac23d7efaa5b0d477ad15deb/core/coreunix/add.go#L86-L101) already. Additionally that would avoid using a test mock, which is questionable to begin with.
Contributor
Author
|
Back to draft as this fails the CI. My assumption was obviously wrong, but I'll use that PR to discuss. If I get that right:
Now, I don't understand why we do this ? Why not just wrap in an empty unixfsdir? Why even wrap? Would there be a way to simplify that code? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems to me that this section of the code is unnecessary as a similar setup would be done in the adder already.
Additionally that would avoid using a test mock, which is questionable to begin with.