Open
Conversation
e518f3a to
53d219d
Compare
Contributor
Author
|
may 26 2022 discussion:
|
Contributor
Author
|
Other possible solution if this drag on too much, revert 04e7e95 in |
lidel
requested changes
Jul 20, 2022
Member
There was a problem hiding this comment.
I'm moving this to 0.15: this needs end-to-end regression tests so we are not surprised when something changes deep in one of libp2p deps. We want tests for two cases:
- confirm two nodes exchange 2MiB block
- confirm two nodes are unable to exchange 2MiB+1 byte block
Contributor
|
What's the priority of this? What is motivating this work? |
Contributor
Author
|
Member
|
This still needs tests described in #8968 (review) |
Contributor
Author
|
I know, I didn't took time to wrote them yet. |
17 tasks
53d219d to
3dd2098
Compare
Contributor
Author
I didnt do this because we don't really have consensus on this: ipfs/specs#331 (comment) |
This is needed because the 1MiB limit is the chunker limit, however the actual blocks can be wrapped in protobuf which adds a small ~10 byte overhead.
3dd2098 to
efc758a
Compare
Contributor
|
Can we close this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed because the 1MiB limit is the chunker limit, however the
actual blocks can be wrapped in protobuf which adds a small ~10 byte
overhead.