feature: Implement --save option in 'ipfs swarm peering add/rm' #9425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajnavarro
requested review from
Jorropo and
guseggert
and removed request for
Jorropo
Jorropo
reviewed
Dec 5, 2022
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
ajnavarro
force-pushed
the
ajnavarro/swarm-peering-save
branch
from
e24d048 to
35efa59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7880 where @Stebalien proposes several new CLI commands. #8147 implements most of the actual functionality.
This PR adds the
--saveoption to bothipfs swarm peering addandipfs swarm peering rm. With this boolean option set, the mutated peering set will be written to the configuration on disk.