Add support for actions - Do not merge!#17
Open
mauropasse wants to merge 41 commits intoirobot-ros:irobot/add-events-executorfrom
Open
Add support for actions - Do not merge!#17mauropasse wants to merge 41 commits intoirobot-ros:irobot/add-events-executorfrom
mauropasse wants to merge 41 commits intoirobot-ros:irobot/add-events-executorfrom
Conversation
Mauro/add events executor
…cutor Renaming
…cutor Add events support
…cutor void return on set_events_executor_callback
…vents-executor Revert "void return on set_events_executor_callback"
…cutor Rename ExecutorEventCallback -> EventsExecutorCallback
Use data types when setting callbacks
Move rcutils/executor_event_types.h to rmw/executor_event_types.h
Rename set_events_executor_callback->set_listener_callback
…ixes Rename callback_context->user_data
Reorder APIs arguments
rename rmw_listener_cb_t->rmw_listener_callback_t
Use void * to pass executor ptr
Rework executor callback data
Use RMW renamed file
irobot-ros
force-pushed
the
irobot/add-events-executor
branch
from
62fdb7b to
0f3ec09
Compare
wjwwood
force-pushed
the
irobot/add-events-executor
branch
2 times, most recently
from
24dc7a6 to
7a366e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating this PR for reference, since the actions support should live in a different branch than
irobot/add-events-executor