Mauro/add events executor#24
Open
mauropasse wants to merge 2 commits intoirobot-ros:irobot/add-events-executorfrom
Open
Mauro/add events executor#24mauropasse wants to merge 2 commits intoirobot-ros:irobot/add-events-executorfrom
mauropasse wants to merge 2 commits intoirobot-ros:irobot/add-events-executorfrom
Conversation
* Add RMW listener APIs Add set_guard_condition_callback api Move apis - Add constness Use or discard previous events: Guard conditions Rename to set_events_executor_callback Rename Event_callback -> ExecutorEventCallback update name Add events support void return on set_events_executor_callback Revert "void return on set_events_executor_callback" Rename ExecutorEventCallback -> EventsExecutorCallback Rename set_events_executor_callback->set_listener_callback Use data types when setting callbacks Move rcutils/executor_event_types.h to rmw/ rename event types Rename executor_context->callback_context Rename callback_context->user_data Reorder APIs arguments rename rmw_listener_cb_t->rmw_listener_callback_t use void * to pass executor ptr Rework executor callback data Use RMW renamed file Signed-off-by: Alberto Soragna <asoragna@irobot.com> * Remove use_previous_event Signed-off-by: Mauro Passerino <mpasserino@irobot.com> * Remove guard condition listener Signed-off-by: Mauro Passerino <mpasserino@irobot.com> * refactor to remove listener term and document Signed-off-by: William Woodall <william@osrfoundation.org> * allow rmw event callback to be NULL to unset them Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com> * Add APIs to support actions on EventsExecutor Signed-off-by: Mauro Passerino <mpasserino@irobot.com> * fix messed up merge Signed-off-by: William Woodall <william@osrfoundation.org> Co-authored-by: Mauro <mpasserino@irobot.com> Co-authored-by: William Woodall <william@osrfoundation.org> Co-authored-by: Alberto Soragna <alberto.soragna@gmail.com>
Signed-off-by: Mauro Passerino <mpasserino@irobot.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should be against
masterofrclsince our changes ofirobot/add-events-executorhave been merged.The new commit in this PR just for illustrating purposes is f5b5109