Add events queue abstract class and implem#40
Merged
irobot-ros merged 9 commits intoirobot-ros:irobot/add-events-executorfrom Feb 8, 2021
Merged
Conversation
alsora
reviewed
Feb 5, 2021
alsora
reviewed
Feb 5, 2021
rclcpp/include/rclcpp/experimental/buffers/performance_events_queue.hpp
Outdated
Show resolved
Hide resolved
alsora
reviewed
Feb 5, 2021
alsora
reviewed
Feb 5, 2021
alsora
reviewed
Feb 5, 2021
alsora
reviewed
Feb 5, 2021
alsora
reviewed
Feb 5, 2021
alsora
reviewed
Feb 5, 2021
rclcpp/include/rclcpp/experimental/buffers/performance_events_queue.hpp
Outdated
Show resolved
Hide resolved
alsora
reviewed
Feb 5, 2021
Collaborator
Author
|
With my latest changes this PR could be merged. |
alsora
reviewed
Feb 5, 2021
| */ | ||
| RCLCPP_PUBLIC | ||
| void | ||
| set_queue_size_limit(size_t queue_size_limit) |
Collaborator
There was a problem hiding this comment.
why not pass this to constructor?
alsora
reviewed
Feb 8, 2021
| bounded_queue->set_queue_size_limit(10); | ||
|
|
||
| // Create an events executor using the bounded queue | ||
| EventsExecutor executor_sub(std::move(bounded_queue)); |
Collaborator
There was a problem hiding this comment.
The unit-tests for the queues should be independent from the executor.
You should just create a queue and start manually pushing/popping things
Collaborator
Author
There was a problem hiding this comment.
Ok I pushed this commit mauropasse@6fb2463
but this PR is not being updated, strange. I'll wait some time to see if gets updated
irobot-ros
approved these changes
Feb 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here I create a pure virtual
EventsQueueclass and an implementationSimpleEventsQueueUsage:
Todo:
Implement in a different PR other policies