Harmonize reconciler logic and improve logging #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
api-change
documentation
afritzler
force-pushed
the
enh/reconciler
branch
from
e8a14ea to
3883e25
Compare
hardikdr
approved these changes
Dec 16, 2025
Member
hardikdr
left a comment
hardikdr
left a comment
There was a problem hiding this comment.
Thanks for all the polishing @afritzler
| if ignitionErr != nil { | ||
| patchError := r.patchStatus(ctx, HTTPBootConfig, state) | ||
| if patchError != nil { | ||
| return ctrl.Result{}, fmt.Errorf("failed to patch status %w %w", ignitionErr, patchError) |
Member
There was a problem hiding this comment.
While we loose reporting the IgnitionErr when Patch fails, I do like simplistic error model here, thanks.
hardikdr
requested changes
Dec 16, 2025
Member
hardikdr
left a comment
hardikdr
left a comment
There was a problem hiding this comment.
Could you please rebase and it's good to go in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
k8s.ioenvtest setup to 1.34