[Draft] Pagetable with no function overriding for adopting stable rust#349
Draft
zpzigi754 wants to merge 5 commits intoislet-project:mainfrom
Draft
[Draft] Pagetable with no function overriding for adopting stable rust#349zpzigi754 wants to merge 5 commits intoislet-project:mainfrom
zpzigi754 wants to merge 5 commits intoislet-project:mainfrom
Conversation
a052623 to
391a3f7
Compare
Signed-off-by: Changho Choi <ch754.choi@samsung.com>
- Pass build errors with is_root - Pass root level in macros Signed-off-by: Changho Choi <ch754.choi@samsung.com>
Signed-off-by: Changho Choi <ch754.choi@samsung.com>
Signed-off-by: Changho Choi <ch754.choi@samsung.com>
391a3f7 to
8cb70b8
Compare
Signed-off-by: Changho Choi <ch754.choi@samsung.com>
fbcc7c7 to
15917e9
Compare
Collaborator
|
I fully understand your motivation. However, level managment seems to be more of PageTable's role rather than Entry's. |
Collaborator
|
Should we look at how other Rust-based OS projects deal with page table management, in the context of 1) using a minimal number of unsafe keyword, 2) using stable rust as much as possible? That might help to some extent. (Also, I'm curious about how other people do this stuff) |
Collaborator
|
Our code is inspired by https://os.phil-opp.com/page-tables/. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of this change is removing
function overriding(specialization feature) in the page table implementation which prevents us from using astable rust.Leveltrait bound instruct PageTable, which is the main place forfunction overriding, has been removed.This PR is just for the reference; it is not aimed to be merged, because it is not the final form of page table I have in mind.
[before]
[after]