Skip to content

animated dragging - dragged TR element actually follows the mouse #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jitbit wants to merge 3 commits into
base: master
Choose a base branch
from
Open

animated dragging - dragged TR element actually follows the mouse #78

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ee7f59e
animated dragging - dragged element actually follows the mouse
Sep 26, 2017
991bad2
fixed bug with first drag in UP-direction
Sep 26, 2017
31f601f
MSIE/Edge workaround
Sep 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 36 additions & 8 deletions js/jquery.tablednd.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,8 @@ jQuery.tableDnD = {
dragObject: null,
/** The current mouse offset */
mouseOffset: null,
/** mouse position where started dragging */
oldMousePosition: null,
/** Remember the old value of X and Y so that we don't do too much processing */
oldX: 0,
oldY: 0,
Expand Down Expand Up @@ -262,6 +264,17 @@ jQuery.tableDnD = {
this.currentTable = table;
this.mouseOffset = this.getMouseOffset(target, e);
this.originalOrder = this.currentOrder();
this.oldMousePosition = this.mouseCoords(e);

//call "findDragDirection" to reset oldX and oldY vars
var mousePos = $.tableDnD.mouseCoords(e);
var x = mousePos.x - $.tableDnD.mouseOffset.x;
var y = mousePos.y - $.tableDnD.mouseOffset.y;
var moving = $.tableDnD.findDragDirection(x, y);

//ie/edge workaround (it has a bug, transform not allowed for TR elements, but allowed for TD, still not fixed, see StackOverflow)
if (this.isIeOrEdge())
$(dragObject).css("display", "block");

// Now we need to capture the mouse up and mouse move event
// We can use bind so that we don't interfere with other event handlers
Expand All @@ -273,6 +286,10 @@ jQuery.tableDnD = {
config.onDragStart
&& config.onDragStart(table, target);
},
isIeOrEdge: function () {
var ua = window.navigator.userAgent;
return ua.indexOf('MSIE ') > -1 || ua.indexOf('Trident/') > -1 || ua.indexOf('Edge/') > -1;
},
updateTables: function() {
this.each(function() {
// this is now bound to each matching table
Expand Down Expand Up @@ -436,12 +453,8 @@ jQuery.tableDnD = {

// auto scroll the window
$.tableDnD.autoScroll(mousePos);

currentRow = $.tableDnD.findDropTargetRow(dragObj, y);
moving = $.tableDnD.findDragDirection(x, y);

$.tableDnD.moveVerticle(moving, currentRow);
$.tableDnD.moveHorizontal(moving, currentRow);

dragObj.css("transform", "translate(" + (mousePos.x - $.tableDnD.oldMousePosition.x) + "px, " + (mousePos.y - $.tableDnD.oldMousePosition.y) + "px)");

return false;
},
Expand Down Expand Up @@ -497,14 +510,23 @@ jQuery.tableDnD = {
}
return null;
},
processMouseup: function() {
processMouseup: function(e) {
if (!this.currentTable || !this.dragObject)
return null;

var config = this.currentTable.tableDnDConfig,
droppedRow = this.dragObject,
parentLevel = 0,
myLevel = 0;

//actually move the element
var mousePos = $.tableDnD.mouseCoords(e);
var x = mousePos.x - $.tableDnD.mouseOffset.x;
var y = mousePos.y - $.tableDnD.mouseOffset.y;
var currentRow = $.tableDnD.findDropTargetRow($(droppedRow), y);
var moving = $.tableDnD.findDragDirection(x, y);
$.tableDnD.moveVerticle(moving, currentRow);
$.tableDnD.moveHorizontal(moving, currentRow);

// Unbind the event handlers
$(document)
Expand Down Expand Up @@ -547,12 +569,18 @@ jQuery.tableDnD = {
// Call the onDragStop method if there is one
config.onDragStop
&& config.onDragStop(this.currentTable, droppedRow);

$(droppedRow).css("transform", "none");

//ie/edge workaround
if (this.isIeOrEdge())
$(droppedRow).css("display", "");

this.currentTable = null; // let go of the table too
},
mouseup: function(e) {
e && e.preventDefault();
$.tableDnD.processMouseup();
$.tableDnD.processMouseup(e);
return false;
},
jsonize: function(pretify) {
Expand Down