Fix Python Editor crash on uninitialised data

SuperSize/CoreLogic/PythonScript.cs

@@ -2,8 +2,10 @@
 using SuperSize.Scripting.Python;
 using SuperSize.UI.Dialogs;
 using System;
+using System.Collections.Generic;
 using System.Drawing;
 using System.Runtime.InteropServices;
+using System.Text;
 using System.Threading.Tasks;
 using System.Windows.Forms;
 
@@ -14,6 +16,11 @@ internal sealed class PythonScript : Logic
 {
     public override string DisplayName => "Scripting: Python";
 
+    public override Dictionary<string, string> InitialSettings => new()
+    {
+        ["Script"] = Encoding.UTF8.GetString(Properties.Resources.PythonSample),
+    };
+
     public override Task<LogicResult> CalculateWindowSize(Settings settings) => Task.Run(() =>
         {
             if (!settings.TryGetValue("Script", out var script))

SuperSize/UI/Dialogs/PythonScriptEditor.cs

@@ -1,32 +1,29 @@
 using Microsoft.Web.WebView2.Core;
 using SuperSize.Model;
+using SuperSize.Properties;
 using SuperSize.Scripting.Python;
 using SuperSize.UI.Forms;
 using System;
 using System.Drawing;
 using System.IO;
 using System.Text;
 using System.Windows.Forms;
+using SettingsDelegate = SuperSize.Model.Settings;
 
 namespace SuperSize.UI.Dialogs;
 
 public partial class PythonScriptEditor : Form
 {
-    private string BaseTitle;
+    private readonly string BaseTitle;
 
-    private Settings Settings { get; }
+    private SettingsDelegate Settings { get; }
 
-    public PythonScriptEditor(Settings settings)
+    public PythonScriptEditor(SettingsDelegate settings)
     {
         Settings = settings;
         InitializeComponent();
 
         BaseTitle = Text;
-
-        if (settings.TryGetValue("Script", out var script))
-        {
-            _scriptEditor.Text = script;
-        }
     }
 
 
@@ -157,6 +154,8 @@ private bool PromptToSaveIfDirty(string? title = null)
 
     private bool IsEditorDirty()
     {
+        if (!Settings.ContainsKey("Script")) return true;
+
         return _scriptEditor.Text != Settings["Script"];
     }
 
@@ -183,7 +182,11 @@ private void OnFormClosing(object sender, FormClosingEventArgs e)
     private void OnNewScriptClicked(object sender, EventArgs e)
     {
         if (!ExportCurrentScript()) return;
+        LoadNewScript();
+    }
 
+    private void LoadNewScript()
+    {
         _scriptEditor.Text = Encoding.UTF8.GetString(Properties.Resources.PythonSample);
         SaveScript();
     }
@@ -197,4 +200,16 @@ private void UpdateTitle()
     {
         Text = BaseTitle + (IsEditorDirty() ? " (unsaved)" : "");
     }
+
+    private void OnFormLoad(object sender, EventArgs e)
+    {
+        if (Settings.TryGetValue("Script", out var script))
+        {
+            _scriptEditor.Text = script;
+        }
+        else
+        {
+            LoadNewScript();
+        }
+    }
 }