Skip to content

add verificationGasLimit overhead #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
itsdeka merged 1 commit into from
May 12, 2025
Merged

add verificationGasLimit overhead #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions packages/relay-kit/src/packs/safe-4337/Safe4337Pack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,6 +432,16 @@ export class Safe4337Pack extends RelayKitBasePack<{
})

if (estimateUserOperationGas) {
if (
feeEstimator.defaultVerificationGasLimitOverhead != null &&
estimateUserOperationGas.verificationGasLimit != null
) {
estimateUserOperationGas.verificationGasLimit = (
BigInt(estimateUserOperationGas.verificationGasLimit) +
BigInt(threshold) * feeEstimator.defaultVerificationGasLimitOverhead
).toString()
}

safeOperation.addEstimations(estimateUserOperationGas)
}

Expand All @@ -446,6 +456,15 @@ export class Safe4337Pack extends RelayKitBasePack<{
})

if (postEstimationData) {
if (
feeEstimator.defaultVerificationGasLimitOverhead != null &&
postEstimationData.verificationGasLimit != null
) {
postEstimationData.verificationGasLimit = (
BigInt(postEstimationData.verificationGasLimit) +
BigInt(threshold) * feeEstimator.defaultVerificationGasLimitOverhead
).toString()
}
safeOperation.addEstimations(postEstimationData)
}

Expand Down
3 changes: 3 additions & 0 deletions packages/relay-kit/src/packs/safe-4337/estimators/generic/GenericFeeEstimator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,16 @@ export class GenericFeeEstimator implements IFeeEstimator {
nodeUrl: string
chainId: string
gasMultiplier: number
defaultVerificationGasLimitOverhead?: bigint

constructor(nodeUrl: string, chainId: string, gasMultiplier: number = 1.5) {
this.nodeUrl = nodeUrl
this.chainId = chainId
if (gasMultiplier <= 0) {
throw new Error("gasMultiplier can't be equal or less than 0.")
}
this.gasMultiplier = gasMultiplier
this.defaultVerificationGasLimitOverhead = 55_000n
}

async preEstimateUserOperationGas({
Expand Down
1 change: 1 addition & 0 deletions packages/relay-kit/src/packs/safe-4337/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@ export type EstimateFeeFunction = ({
export interface IFeeEstimator {
preEstimateUserOperationGas?: EstimateFeeFunction
postEstimateUserOperationGas?: EstimateFeeFunction
defaultVerificationGasLimitOverhead?: bigint
}

export type EstimateFeeProps = {
Expand Down
Loading