Use toggle attributes on root document instead css vars for managing UI states #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… vars for managing UI states - Refactor `useToggleStorage` and `hideThinkingProcess` to toggle attributes on the `<html>` element instead of directly modifying CSS variables - Replace direct CSS variable updates with attribute-based toggling for cleaner, more maintainable, and extensible code - Ensure the new approach is DRY (Don't Repeat Yourself) and easier to extend for future elements or features Changes summary: - Refactored the logic for managing UI states like the thinking process visibility. Instead of directly modifying CSS variables, the implementation now toggles attributes on the `<html>` element. This approach improves code clarity, reduces redundancy, and makes it easier to extend functionality for new elements in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the logic for managing UI states like the thinking process visibility. Instead of directly modifying CSS variables, the implementation now toggles attributes on the
<html>element. This approach improves code clarity, reduces redundancy, and makes it easier to extend functionality for new elements in the future.