Rewrite and optimize the accent color logic #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions - slice() > substr() (deprecated and slower) - Multiplication instead of division where possible - Bitwise OR (| 0) for faster float-to-int conversion - padStart() instead of manual zero-padding logic - Reduced conditional branches in HSL conversion
…and clean up watchers to prevent mem leak - Refactor custom colors logic by encapsulating the color picker into a dedicated, reusable component - Clean up color watchers when the component is unmounted to prevent memory leaks and improve performance - Improve code modularity and maintainability by isolating color picker functionality Changes summary: - Refactored the custom colors implementation by wrapping the color picker into a separate component. This improves code organization and reusability. Additionally, color watchers are now cleaned up when the component is unmounted, ensuring better performance and preventing potential memory leaks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.