Skip to content

Add API calls for removing testers and group in sync push command #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
DechengMa wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add API calls for removing testers and group in sync push command #242

DechengMa wants to merge 1 commit into from

Conversation

@DechengMa
Copy link
Contributor

@DechengMa DechengMa commented Oct 13, 2020

Add API calls for removing testers and group in sync push command

📝 Summary of Changes

Changes proposed in this pull request:

  • Add dry-run flag to push command
  • Create required service function for push command
  • Wire up removing logic in sync such command

🧐🗒 Reviewer Notes

💁 Example

swift run asc testflight sync push --dry-run

Beta Tester with email: foo+91@gmail.com will be removed from groups: New Group 3 in apps: com.exmaple.foo
Beta Tester with email: foo+138@gmail.com will be removed from groups: New Group 3 in apps: com.exmaple.foo
Beta Tester with email: foo+142@gmail.com will be removed from groups: New Group 3 in apps: com.exmaple.foo

swift run asc testflight sync push 

✅  Beta Tester with email: foo+91@gmail.com will be removed from groups: New Group 3 in apps: com.exmaple.foo
✅  Beta Tester with email: foo+138@gmail.com will be removed from groups: New Group 3 in apps: com.exmaple.foo
✅  Beta Tester with email: foo+142@gmail.com will be removed from groups: New Group 3 in apps: com.exmaple.foo

🔨 How To Test

swift run asc testflight sync push --dry-run

swift run asc testflight sync push

@DechengMa DechengMa added the enhancement New feature or request label Oct 13, 2020
@DechengMa DechengMa self-assigned this Oct 13, 2020
@DechengMa DechengMa marked this pull request as draft November 30, 2020 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamjcampbell adamjcampbell Awaiting requested review from adamjcampbell

At least 1 approving review is required to merge this pull request.

Assignees

@DechengMa DechengMa

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DechengMa