-
Notifications
You must be signed in to change notification settings - Fork 6
Update of the Appendix A #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I would prefer to keep the nomenclature hea in ivoa.obscore-hea rather than changing to ivoa.obscore_he. HEA ("High Energy Astrophysics") is well recognized as spanning the energy range from soft X-ray to the highest energies observed. However, HE ("High Energy") can be mistaken for a restricted energy band that covers just a part of that energy range. Since we want this extension to span the all of high energy astrophysics unambiguously I suggest keeping hea. As to whether to use a "-" or an "_", I tried to follow other draft proposed obscore extensions although I note these have migrated somewhat. Draft 1.0 (2024-07-17) of the time extension I have uses "-" (see section 5 where it mentions "... different tables : ivoa.obscore, ivoa.time-obscore, ivoa.radio-obscore, ivoa.heig-obscore etc...), although draft 1.0 (2024-06-14) of the radio extension seems to use both ivoa.obscore_radio and ivoa.ObscoreRadioExtended in different parts of the document. Perhaps some standardization discussion would be beneficial? |
I might be wrong, but sincewADQL is currently implemented in PostGRESql, it doesn't allow for column or table names to have hyphens in them. I agree with keeping the "A" though, we can just redefine the glossary entry for \gls{HE} to have "HEA" as the abbreviation everywhere. |
| \item dataproduct\_type = ``event-bundle'' | ||
| \end{enumerate} | ||
|
|
||
| \begin{verbatim} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tip: if you want this to look nicer, use the minted package and then do:
% in the header
\usepackage{minted}
\usemintedstyle{friendly}
...
\begin{minted}{sql}
SELECT * FROM ivoa.obscore
NATURAL JOIN ivoa.obscore_he
WHERE
(target_name = 'Cas A' OR CONTAINS(POINT(s_ra, s_dec), CIRCLE, 350.8584, +58.8113, 0.16667) = 1)
AND (dataproduct_type = 'event-bundle')
AND (ev_xel >= 1000000)
\end{minted}
Then you get nice syntax highliting like:
SELECT * FROM ivoa.obscore
NATURAL JOIN ivoa.obscore_he
WHERE
(target_name = 'Cas A' OR CONTAINS(POINT(s_ra, s_dec), CIRCLE, 350.8584, +58.8113, 0.16667) = 1)
AND (dataproduct_type = 'event-bundle')
AND (ev_xel >= 1000000)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great... I will make the editing in this direction ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunatly, the IVOA standard Makefile is using latexmk, and this is not compatible. To be checked later
|
It's true that the minus sign "-" is not a legal character in an ADQL identifier, while underscore "_" is (see ADQL 2.1 sec 2.1.5). So it's a good idea to avoid minus signs in table names, otherwise you'll have to mess with delimited identifers, e.g. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking if we expose data from existing IACT like HESS/MAGIC/VERITAS, it would be nice to show an example of using the analysis_mode or event_type (in the case of Fermi). That would be a good example of why we need those.
Also, a common use case for IACTs in particular would be to find all event-bundles for observations of a source that were taken at a zenith angle below 40 degrees, for example (since zenith angle affects energy threshold and PSF and other aspects). Is that possible with ObsCore? Or would that only be possible with specialized observatory-specific science archives? If not, what is the recommendation: to use the s_angres or energy_min values? If so, then are they specified sufficiently that they would give the same result? e.g. are we required (recommended?) to fill energy_min such that it is the threshold energy , vs some generic bracketing energy?
I agree, this is why I made
Indeed, the optional fields of a data release.... I forget to discuss that in the document. Very good point... Having a recommendation just for the IACT could be difficult to accept. But the notion of "optional fields proper to a data release", it might be great... I will discuss this point and if accepted I will add a UC. |
Some of those optional fields could also be standardized, since things like the horizontal coordinates (or air column density, or similar) are not specific to HEA instruments, but to any ground-based instrument. |
If you have any concrete proposal, do not hesitate ;) |
This PR update the list of Use Cases:
@ Mireille and François: could you check the DataLink releated topics?